Update OpenBLAS Version for x86 Wheel Build #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofuyu
reviewed
Feb 25, 2022
.github/build_pypi_wheel.sh
Outdated
| # https://github.com/mattip/numpy/blob/1edb44669f9acddebd92df794ca9731fd92f4e06/tools/openblas_support.py#L49 | ||
| wget https://anaconda.org/multibuild-wheels-staging/openblas-libs/v0.3.19-22-g5188aede/download/openblas-v0.3.19-22-g5188aede-manylinux2014_aarch64.tar.gz | ||
| tar -xvf openblas-v0.3.19-22-g5188aede-manylinux2014_aarch64.tar.gz | ||
| wget "https://anaconda.org/multibuild-wheels-staging/openblas-libs/v0.3.19-22-g5188aede/download/openblas-v0.3.19-22-g5188aede-$PLAT.tar.gz" |
There was a problem hiding this comment.
Given that the string "v0.3.19-22-g5188aede" is used multiple times, maybe we can set it to a variable and replace the string with the variable?
weiliw-amz
force-pushed
the
update-x86-wheel-openblas
branch
from
e069f7b to
edbb630
Compare
rofuyu
approved these changes
Feb 25, 2022
rofuyu
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Previous OpenBLAS shared library included in PECOS x86 wheel, is installed from CentOS repo and is v0.3.3.
However, fortunately, Numpy provides pre-build up-to-date OpenBLAS libraries for multi-platform wheel build hosted by Anaconda, and we could also use them in PECOS wheel build.
For details, please refer to:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.