Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update numpy, scipy, OpenBLAS, and setuptools version #296

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Update numpy, scipy, OpenBLAS, and setuptools version #296

merged 3 commits into from
Aug 10, 2024

Conversation

vpung
Copy link
Contributor

@vpung vpung commented Aug 6, 2024 •
edited
Loading

Issue #, if available:
N/A

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@OctoberChang OctoberChang self-requested a review August 6, 2024 18:55
@OctoberChang OctoberChang added the dependencies Pull requests that update a dependency file label Aug 6, 2024
@vpung vpung changed the title Update scipy/numpy version Patch numpy, scipy, OpenBLAS, and setuptools version Aug 6, 2024
@vpung vpung changed the title Patch numpy, scipy, OpenBLAS, and setuptools version Update numpy, scipy, OpenBLAS, and setuptools version Aug 6, 2024
@vpung vpung requested a review from weiliw-amz August 6, 2024 19:41
@vpung vpung force-pushed the patch-dependency branch from ab1715a to 2989309 Compare August 6, 2024 19:50
weiliw-amz
weiliw-amz approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@weiliw-amz weiliw-amz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@vpung vpung marked this pull request as ready for review August 6, 2024 21:38
OctoberChang
OctoberChang approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@OctoberChang OctoberChang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge this once all unit tests and PyPI build complete, thanks.

@vpung vpung merged commit f222c94 into mainline Aug 10, 2024
49 checks passed
@vpung vpung deleted the patch-dependency branch August 10, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiliw-amz weiliw-amz weiliw-amz approved these changes

@OctoberChang OctoberChang OctoberChang approved these changes

Assignees

@vpung vpung

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpung @OctoberChang @weiliw-amz