Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete android sample is quite outdated #601

Closed
mkovalyk opened this issue Apr 13, 2021 · 3 comments
Closed

Complete android sample is quite outdated #601

mkovalyk opened this issue Apr 13, 2021 · 3 comments

Comments

@mkovalyk
Copy link
Contributor

Sample from https://github.com/amzn/style-dictionary/tree/3.0/examples/complete/android looks to be quite outdated. It:

  • targets and compiles with API 25.
  • referencing to build tools 25..
  • uses deprecated support libraries
  • uses Java
@mkovalyk mkovalyk mentioned this issue Apr 13, 2021
Merged
@dbanksdesign
Copy link
Member

Thank you for raising this. You are correct the complete example for Android (and iOS and web) are quite outdated.

@mkovalyk
Copy link
Contributor Author

I have created PR to resolve it. It would be nice if someone could merge it in. Thanks!

dbanksdesign pushed a commit that referenced this issue May 3, 2021
@mkovalyk
chore(example): update complete android example (#602)
f0e571c 
Fixes #601 

* Remove butterknife
* Update gradle to 6.8.2 and gradle plugin 4.1.3
* Use androidX
* Compile and Target SDK - 30
* Add kotlin support.
* Convert Java to Kotlin
* Upgrade Jackson library to 2.12.3
* Remove unused and commented out code, fix license text

Co-authored-by: mykhailo.kovalyk <mykhailo.kovalyk@eleks.com>
@dbanksdesign
Copy link
Member

Thank you for your contribution! This is now merged into the 3.0 branch and released in 3.0.0-rc.9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbanksdesign @mkovalyk