fix(formats): added nested property to json/asset #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the late response, I think this PR is still valid and hasn't been fixed yet in main branch, could you rebase your PR on the latest branch? https://github.com/amzn/style-dictionary/blob/main/lib/common/formats.js#L1540 And when you're done, running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We are getting a lot of warnings during tokens' generation mentioning name collisions.
I started looking into this and discovered the
nestedformat idea, which works great for the formats where it's set up (and we had to add it to a few of our formats), but then I realized I was still getting errors during asset files generation with thejson/formatformat.Looking at the code + at its output, it seems like this format is a nested format too, but I am guessing it was missed during the time where nested formats where introduced.
So this PR is just making the
json/formatofficially anestedformat, so there won't be anymore wrong warnings for it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.