Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages (prerelease) #1050

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Version Packages (prerelease) #1050

merged 1 commit into from
Nov 28, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to v4, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

v4 is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on v4.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

style-dictionary@4.0.0-prerelease.2

Major Changes

  • a4542f4: BREAKING: StyleDictionaryInstance.properties & .allProperties have been removed. They were deprecated in v3 in favor of .tokens and .allTokens.

  • a4542f4: BREAKING: StyleDictionary to be initialized with a new API and have async methods. Use:

    import StyleDictionary from 'style-dictionary';
    
    /**
     * old:
     *   const sd = StyleDictionary.extend({ source: ['tokens.json'], platforms: {} });
     *   sd.buildAllPlatforms();
     */
    const sd = new StyleDictionary({ source: ['tokens.json'], platforms: {} });
    await sd.buildAllPlatforms();

    You can still extend a dictionary instance with an extended config, but .extend() is only used for this, it is no longer used to initialize the first instance:

    import StyleDictionary from 'style-dictionary';
    
    const sd = new StyleDictionary({ source: ['tokens.json'], platforms: {} });
    const extended = await sd.extend({
      fileHeader: {
        myFileHeader: (defaultMessage) => {
          return [...defaultMessage, 'hello, world!'];
        },
      },
    });

    To ensure your initialized StyleDictionary instance is fully ready and has imported all your tokens, you can await hasInitialized:

    import StyleDictionary from 'style-dictionary';
    
    const sd = new StyleDictionary({ source: ['tokens.json'], platforms: {} });
    await sd.hasInitialized;
    console.log(sd.allTokens);

    For error handling and testing purposes, you can also manually initialize the style-dictionary config:

    import StyleDictionary from 'style-dictionary';
    
    const sd = new StyleDictionary({ source: ['tokens.js'], platforms: {} }, { init: false });
    try {
      await sd.init();
    } catch (e) {
      // handle error, e.g. when tokens.js file has syntax errors and cannot be imported
    }
    console.log(sd.allTokens);

    The main reason for an initialize step after class instantiation is that async constructors are not a thing in JavaScript, and if you return a promise from a constructor to "hack it", TypeScript will eventually trip over it.

    Due to being able to dynamically (asynchronously) import ES Modules rather than synchronously require CommonJS modules, we had to make the APIs asynchronous, so the following methods are now async:

    • extend
    • exportPlatform
    • buildAllPlatforms & buildPlatform
    • cleanAllPlatforms & cleanPlatform

    In a future release, most other methods will be made async or support async as well, such as parsers, transforms, formats etc.

Minor Changes

  • cedf8a0: Preprocessors are a new feature added to style-dictionary, which allows you to do any type of processing of the token dictionary after parsing, before resolving and transforming.
    See preprocessor docs for more information.
  • a4542f4: options.log to be respected in all error logging, including platform specific logs.

@github-actions github-actions bot requested a review from a team as a code owner November 28, 2023 10:51
@jorenbroekema jorenbroekema merged commit efbfeee into v4 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant