Android support for fonts & textCase via textAllCaps #1331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed earlier in the this PR includes two things:
fontFamily
to an android-ressource entry like<item name="typography_body_font_family" type="font">@font/comic_sans_regular</item>
❗️to fully support this, i also use the following transform, which is not included yet
Usage: the value can be used with https://developer.android.com/reference/android/widget/TextView#attr_android:fontFamily - please ensure that the font-file has the same name
textCase
to a bool android ressource like this:<bool name="typography_body_text_case">false</bool>
❗️this also needs a transform:
Usage: the generated resource can be used with https://developer.android.com/reference/android/widget/TextView#attr_android:textAllCaps
From our point of view, this would be a big improvement.