chore: dropped node 8 support #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanksdesign
requested changes
Jul 20, 2020
There was a problem hiding this comment.
Thank you for this contribution!
I'm thinking we should drop Node 10 as well and be on Node 12 as Node 10 is currently is in "maintenance" and 12 is "active" for now. Could we also add Node 14 in the travis yaml file? What do you think?
Also, I switched the branch to our 3.0 branch because dropping support for Node 8 is a breaking change. The 3.0 release will include some other major features so I thought it was best to group them under one major version release.
dbanksdesign
pushed a commit
that referenced
this pull request
Oct 5, 2020
* Added node v14 in .travis.yml + bumped up nodejs to v12 (package.json)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #437:
Dropped Node 8 support by modifying package.json and .travis.yml files
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.