chore(tests): add eslint-jst and fix lint errors #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazzmoney
reviewed
Nov 26, 2020
__tests__/formats/scssMaps.test.js
Outdated
| @@ -207,7 +207,7 @@ var dictionary = { | |||
| describe('formats', () => { | |||
| _.each(['scss/map-flat', 'scss/map-deep'], function(key) { | |||
|
|
|||
| describe(key, () => { | |||
| describe(`${key}`, () => { | |||
There was a problem hiding this comment.
This might be a rule we could disable... There is a lint rule that describe blocks must have a string as the title and the linter isn't smart enough to know that those variables are strings...
|
Minus that one template string that I don't understand, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Adding eslint-jest so we can better lint our tests. Also fixing the errors and warnings that came up from linting.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.