refactor(transforms): add platform option 'basePxFontSize' #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarreiros
force-pushed
the
basePxFontSize-option
branch
from
a50fc78 to
499f6c3
Compare
jbarreiros
force-pushed
the
basePxFontSize-option
branch
from
95e7836 to
69018bc
Compare
|
Rebased, and updated This should be good to go. |
dbanksdesign
pushed a commit
that referenced
this pull request
Jan 25, 2021
Adds basePxFontSize platform option which allows you to set the base px font size for pixel transforms. The default remains the same, 16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
Per this conversation, this PR adds a
basePxFontSizeplatform option, and updates eachremTo*transform to use it.Also added missing unit tests for
size/swift/remToCGFloat.I realize that either this PR or #491 will need a quick update, depending which is merged first. Let me know what you want me to do.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.