Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix security dependency in cra example #521

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

dbanksdesign
Copy link
Member

@dbanksdesign dbanksdesign commented Jan 22, 2021

Issue #, if available:

Description of changes: The immer dependency has a security vulnerability. However, it is a nested dependency of react-scripts which has not yet updated its dependency. To get around this we are going to use npm-force-resolutions to fix the immer version at 8.0.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chazzmoney
Copy link
Collaborator

Silly to have to do this, but safer for our users. Thanks @dbanksdesign

LGTM :shipit:

@chazzmoney chazzmoney merged commit 331385b into main Jan 23, 2021
@dbanksdesign dbanksdesign deleted the fix-security-immer branch March 12, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants