-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(json/original): Add json/original format #737
base: main
Are you sure you want to change the base?
Conversation
Hi @theKosh , thanks for your contribution! This is a good idea, but needs some changes. I'll add all of the comments below as a review, but I wanted to try to capture all the thinking in one spot:
Thanks again for your contribution! Looking forward to adding in this functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. A few changes to get it all in line for merge. Thanks!
Hi @chazzmoney.
Yes, okay, I'll do it.
For example:
There is a discussion of the problem in this topic.
I'll fix it. Thanks for the detailed code review. I'll try to do everything in my spare time. |
Hi, @chazzmoney. I fixed all the errors and added the Sorry it took so long — I got tied up at work. |
Issue #727
Description of changes:
The json/original format allows you to leave only those keys that were specified in the original object without additional metadata. More info [Question] - Is there a way to not include default metadata when formatting in a JSON format? #727.
Added dictionary filtered function:
In:
dictionary.tokens.color
to it.Out: the object which contains only given keys.
Tested with the Figma Tokens plugin.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.