Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game does not run well with --run-game, when predownload available #327

Closed
blmarket opened this issue Jan 30, 2024 · 3 comments · Fixed by #354
Closed

Game does not run well with --run-game, when predownload available #327

blmarket opened this issue Jan 30, 2024 · 3 comments · Fixed by #354

Comments

@blmarket
Copy link
Contributor

https://github.com/an-anime-team/an-anime-game-launcher/blob/main/src/main.rs#L232

Because I didn't use --just-run-game, it will fall through match and go with app.run() which does not understand --run-game option and fails.

Can we add another match case when predownload available && run_game flag, and panic with some helpful message such as "hey, predownload available, do something other than --run-game (or --just-run-game if you really don't want to see the ui)"?
@krypt0nn
Copy link
Member

This behavior is expected. Launcher should start if --run-game provided but some additional action is available

@krypt0nn
Copy link
Member

Mkrsym explained the problem to me a bit, the launcher crashing issue will be fixed in the next update

@blmarket
Copy link
Contributor Author

Can't find the fix from next branch. Let me know if you would welcome PR.

blmarket added a commit to blmarket/an-anime-game-launcher that referenced this issue Mar 24, 2024
@blmarket
Show some helpful error when --run-game cannot work
860a847 
Instead of just try to run UI with invalid argument to fail,
it will just fail with better error messages.

Fixes an-anime-team#327
@blmarket blmarket mentioned this issue Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show some helpful error when --run-game cannot work blmarket/an-anime-game-launcher
2 participants
@blmarket @krypt0nn