Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modernize #11

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

Chris53897
Copy link

Hi. I made some changes to keep this good idea alive for newer symfony versions.
There is still some work left.

I have created a first draft for a demo.
https://github.com/Chris53897/ImageCropBundleDemo

I did not use the bundle before, so i would be glad for some input from you.
My main question is: How is the Crop saved?
I do not see andy save button.

Changelog:
Dropped Support for PHP < 8
Dropped Support for Symfony < 4.4
Add Support for Symfony 4,5,6
Started to add Unittests
Add the missing symfony components to composer
Changed directory /web/ to /public/ The default Folder for symfony 4 and symfony flex

@anacona16
Copy link
Owner

Hi @Chris53897 thanks for contributing to the this project, actually I do not use this bundle a long time ago.

I was checking your changes, there are a lot of updated files.

I will continue checking all the changes.

I will post a more technically explanation about how it works, but it will take some days, I'm stuck at work right now.

@Chris53897
Copy link
Author

@anacona16 Thanks for the reply. Take your time, no need for hussle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants