-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda 4.4+ support (conda not on path errors) #75
base: master
Are you sure you want to change the base?
Conversation
Fixes conda>=4.4 installs where conda is not on the path.
uses conda shell script instead of adding conda on path. Also fixes flake8 error in a test
(This also incorporates #74 to get tests passing again) |
Added @voidworker's fix from #66, which handles new behavior of |
Hi @tjd2002 how is your fork doing? Given this project doesn't seem maintained I was thinking about switching to your branch but maybe you faced new issues and no longer using nb_conda ? |
Has there been any progress merging this in? |
I would like to see this merged, but I don't use the conda tab anymore. (I think that Anaconda Navigator is the recommended way to manage conda envs if you need a GUI). Note that you can still use conda kernels with Jupyter by installing the nb_conda_kernels package. |
@mcg1969 Any interest in pushing this forward? |
This repo seems to be quite soundly dead but there's an actively-developed fork at : https://github.com/fcollonval/jupyter_conda (Thanks @fcollonval) |
Uses the $CONDA_EXE environment variable to find conda, rather than assuming it's on the path. Inspired by (and fixes the same problems as: anaconda/nb_conda_kernels#79 )
Also adds Travis testing for new- and old-style installs (borrowing from: anaconda/nb_conda_kernels#82 and anaconda/nb_conda_kernels#83)
Discussion of 4.4+ support across all nb extensions at: https://github.com/Anaconda-Platform/anaconda-nb-extensions/issues/168