Add Content-Disposition Header

[varbhat]

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

It helps Downloaders to detect Filename of the file.

[anacrolix]

@varbhat maybe try something like https://github.com/anacrolix/confluence/blob/master/confluence/handlers.go#L39-L41, I've had to implement this many times, and it's a deep rabbit hole. Are you sure about attachment? I know it's part of the spec but can you operate without it? I wonder if some players will misinterpret it.

[varbhat]

@anacrolix, I am using Download Navi App for Downloading. If attachment is not present, it doesn't resolve the filename :(

[anacrolix]

@varbhat that's fine, I just wanted to check. Can you use the linked to form and I'll merge.

[anacrolix]

@varbhat just following up, do you want to update this patch to quote the filename per the link (and retaining the attachment if that wasn't clear).

[varbhat]

@anacrolix ,
I have been using my own fork with this commit (https://github.com/varbhat/dms/commit/cc3a1df8daaafec41fcbb47b6d52984f8aa473a9).

What should be changed? Should i update this PR to include implementation similar to that of confluence?

[anacrolix]

I think it needs to be something like w.Header().Set("Content-Disposition", "attachment; filename="+strconv.Quote(filename)).

[varbhat]

@anacrolix #115

[anacrolix]

Thanks!