use RenderTree for tree display #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anafvana
force-pushed
the
rendertree-display
branch
from
950c89c
to
a4d7820
Compare
|
Hey @UnknownUser95! Sorry for the almost year-long delay on this one too. I tested your code and it's failing the tests (specifically the test case Since it's neither a bug fix nor a new feature per sé, I won't put the time into finding what's wrong and fixing it. I'll close the pull request, but if you want to fix the issue and re-open the PR, I can reconsider, of course. Thanks for contributing either way! Your other PR was lovely and has been approved. |
|
I knew I forgot something: the tests! I'll fix the test and reopen, but that may take a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't happy with the current layout of the tree style.
While it is really cool to see, that you implemented your own tree style, it is simpler to use the style from anytrees' RenderTree.
(also sorry for committing the pycodestyle change and using RenderTree in the same commit. I realized it too late.)