Windows dependencies build #1197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New flow for mingw builds on windows operating system is implemented by installing the nedeed dependencies and build libiio with the bash from msys2 that supports also mingw64. The dependencies will be installed with pacman. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
With the new script added we can build libiio via msys2 bash using also dependencis installed with pacman. By removing the old dll files that were downloaded from an archive the paths to the dependencies needed to be modified and now they are copied from the mingw64 folder. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
This script will clone and download different dependencies of the libiio in order to build them with the msvc compiler. Using msbuild that is the visual studio program designed for terminal builds of visual studio projects. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
Switch to new script and modify the paths form cmake command and also the path from where the dll files were copied. The old script build_win.ps1 was renamed in build_win_msvc.ps1 because now it supports just the msvc compiler, eliminating the support for mingw because was not needed anymore. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
After new libraries build the nameing of some files was changed and also the file was not updated with the lates changes. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
AAndrisa
requested review from
cristina-suteu,
dNechita,
mhennerich and
SRaus
as code owners
rgetz
reviewed
Sep 13, 2024
There was a problem hiding this comment.
in general - this looks great. Thanks
I think you need to distribute the source of the dependencies to be license complainant. (not just the dlls). Although - I don't see the point in doing this in a giant tar - just in the source tar, the dependencies should be there as well.
plus - don't forget to fix the Codacy issue pointed out.
-Robin
| FOR /F "USEBACKQ TOKENS=*" %%F IN (`%vswhere% !vswhere_params! -requires Microsoft.Component.MSBuild -find MSBuild\**\Bin\MSBuild.exe`) DO ( | ||
| SET msbuild="%%F" | ||
| ) | ||
| :: clone the zstd repo and build it with the desierd configuration |
There was a problem hiding this comment.
desierd
should be desired? (spelling)
| cmake --build libxml2-build --config Release --target install | ||
|
|
||
| :: clone and build libserialport project | ||
| git clone https://github.com/sigrokproject/libserialport.git |
There was a problem hiding this comment.
for other repos - you are getting specific versions. for libserialport - you are grabbing tip of master - is that what you want to do? (I'm not sure there is a better idea, since the newest release is so old)...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In the old flow the needed dependencies were downloaded from a zip, and for msvc and mingw compiler were used the same files.
Now each compiler has its own specific dependencies.
Artifact manifest was updated and also publish deps script with the corresponding paths of the new files.
This PR is related to #1183
PR Type
PR Checklist