ContextBuilder: solve context close bug using reference count #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Adrian-Stanea
commented
Sep 27, 2023
Adrian-Stanea
commented
- added reference count to ContextBuilder to keep track of how many external references to the M2k context are present. When the last reference is removed, the M2k context can be closed.
- contexts should be closed in the reverse order they were opened: contextClose() -> iio_context_destroy() to avoid pointer errors.
- based on context ownership, the user of the API is responsible of deinitalizing resources.
AlexandraTrifan
approved these changes
Oct 2, 2023
adisuciu
requested changes
Oct 2, 2023
Adrian-Stanea
force-pushed
the
bugFix_context_ownership
branch
from
0c78649 to
03943ba
Compare
AlexandraTrifan
approved these changes
Dec 7, 2023
adisuciu
approved these changes
Jan 29, 2024
- added reference count to ContextBuilder to keep track of how many external references to the M2k context are present. When the last reference is removed, the M2k context can be closed. - contexts should be closed in the reverse order they were opened: contextClose() -> iio_context_destroy() to avoid dangling pointers. Signed-off-by: Adrian Stanea <Adrian.Stanea@analog.com>
AlexandraTrifan
force-pushed
the
bugFix_context_ownership
branch
from
03943ba to
da2ce29
Compare
AlexandraTrifan
merged commit 2499612
into
analogdevicesinc:master
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.