Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC: MAX31331: Support and documentation for RTC MAX31331 #2593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RTC: MAX31331: Support and documentation for RTC MAX31331 #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d69eef
rtc: max31335: Add driver support for MAX31331
SwaroopPKADI Sep 6, 2024
6f413ca
dt-bindings: rtc: max31335: Add max31331 support
SwaroopPKADI Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions Documentation/devicetree/bindings/rtc/adi,max31335.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ description:
Analog Devices MAX31335 I2C RTC ±2ppm Automotive Real-Time Clock with
Integrated MEMS Resonator.

allOf:
- $ref: rtc.yaml#

properties:
compatible:
const: adi,max31335
enum:
- adi,max31331
- adi,max31335

reg:
maxItems: 1
items:
- enum: [0x68, 0x69]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thin you can just keep maxItems. Below you already make it clear the addresses.

I'll also take the opportunity to advise on the commit message. Maintainers are getting more strict about having fallbacks devices. In short fallback is a way for an older kernel (which does not contain the new device driver - in this case max31331) to still be able to use and probe the fallback device (in this case max31335). The reasoning is that we can't still operate the device but just missing some features.

That said, if they are not compatible at all (i.e - we can't fallback into the other device), we need to state why is that in the commit message.


interrupts:
maxItems: 1
Expand Down Expand Up @@ -50,6 +50,26 @@ required:

unevaluatedProperties: false

allOf:
- $ref: rtc.yaml#

- if:
properties:
compatible:
contains:
enum:
- adi,max31335
then:
properties:
reg:
items:
- const: 0x69
else:
properties:
reg:
items:
- const: 0x68

examples:
- |
#include <dt-bindings/interrupt-controller/irq.h>
Expand All @@ -59,7 +79,7 @@ examples:

rtc@68 {
compatible = "adi,max31335";
reg = <0x68>;
reg = <0x69>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this. Why going in favor of the new reg? If you really want, add another example for the new device.

pinctrl-0 = <&rtc_nint_pins>;
interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
aux-voltage-chargeable = <1>;
Expand Down
Loading