Force ADMV8818 soft reset and SDO initialization #2700
Conversation
swinchen
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
swinchen
force-pushed
the
force_configure_admv8818
branch
2 times, most recently
from
07cb9a2 to
aee2d29
Compare
There was a problem hiding this comment.
Hi @swinchen, thanks for contributing... Change looks good to me. The only thing I want to mention is the commit message. Please run git log --oneline drivers/iio and follow the same style for the commit subject.
Another thing I'd like to mention is that I would like to see this patch first sent upstream. Are you comfortable with that?
swinchen
force-pushed
the
force_configure_admv8818
branch
from
aee2d29 to
f851ce8
Compare
Hi @nunojsa - I have corrected the commit one line commit message. Sorry I missed that in my first past. By upstream, do you mean Torvalds? I checked the maintainers list and the other option might be this list: linux-iio@vger.kernel.org If you point me to the right place I am happy to push it upstream unless that is something you handle. |
|
Hi, Sorry I missed it. Anyways, I can see you already figured it out and the patch is already applied. Please cherry-pick the applied patch and update this PR. It should be available here after merge window is over: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/ |
No worries - I hope I did it correctly. Would you like me close this branch and re-open a new PR with the cherry-picked commit? Where can you see that the patch was already applied? I do not see any activity of the v2 patch. Thanks for the assistance. |
As you prefer... You can just update this PR with the cherry-picked patch and force push it...
It should be available in one of the branches (likely the fixes one) in here: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/ But should be only available next week after merge window is over. |
|
@swinchen your patch is already pushed in IIO tree: Could you cherry-pick and update this? Otherwise I can also do it... |
When a weak pull-up is present on the SDO line, regmap_update_bits fails to write both the SOFTRESET and SDOACTIVE bits because it incorrectly reads them as already set. Since the soft reset disables the SDO line, performing a read-modify-write operation on ADI_SPI_CONFIG_A to enable the SDO line doesn't make sense. This change directly writes to the register instead of using regmap_update_bits. Fixes: f34fe88 ("iio:filter:admv8818: add support for ADMV8818") Signed-off-by: Sam Winchenbach <swinchenbach@arka.org> Link: https://patch.msgid.link/SA1P110MB106904C961B0F3FAFFED74C0BCF5A@SA1P110MB1069.NAMP110.PROD.OUTLOOK.COM Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
swinchen
force-pushed
the
force_configure_admv8818
branch
from
f851ce8 to
6b24ab9
Compare
Cherry-picked and pushed. Sorry this took so long. |
When a weak pull-up is present on the SDO line, regmap_update_bits fails to write both the SOFTRESET and SDOACTIVE bits because it incorrectly reads them as already set.
Since the soft reset disables the SDO line, performing a read-modify-write operation on ADI_SPI_CONFIG_A to enable the SDO line doesn't make sense. This change directly writes to the register instead of using regmap_update_bits.
PR Type
PR Checklist