feat(Examples): Firmware update through HCI for MAX32655 #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32655
|
/clang-format-run |
EricB-ADI
reviewed
Jul 30, 2024
| uint8_t * addressErase = (uint8_t*) addr; | ||
|
|
||
| BSTREAM_TO_UINT32(size, pBuf); | ||
| volatile uint32_t address32 = (uint32_t)addressErase; |
There was a problem hiding this comment.
What is addresss32 for? I only see it set
There was a problem hiding this comment.
What is addresss32 for? I only see it set
Sorry, this becomes unused after several changes. Deleted.
| //this is the callback function to the Msg | ||
| void device_reset(wsfEventMask_t event, wsfMsgHdr_t *pMsg) | ||
| { | ||
| MXC_Delay(3000); |
There was a problem hiding this comment.
Do you need the delay?
I think yes, without the delay, the reset will be completed before HCI sends the status code back.
There was a problem hiding this comment.
That delay is blocking. meaning nothing is going on when you run it.
There was a problem hiding this comment.
Instead of doing an event with a delay just use a one
shot timer
EricB-ADI
changed the title
uart merge
EricB-ADI
approved these changes
Sep 3, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 3, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a firmware update example: update the firmware through HCI
Add HCI command to be used during the update: erase, update, sysreset