-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PeriphDrivers): Fix UART Functional Regression for MAX32670, MAX32672, MAX32675, MAX32657 #1150
fix(PeriphDrivers): Fix UART Functional Regression for MAX32670, MAX32672, MAX32675, MAX32657 #1150
Conversation
- Fix SetFrequency implementation - Update SetClockSource implementation - Add support for AOD_CLK for UART3
- Fix SetFrequency implementation - Update SetClockSource implementation - Add support for AOD_CLK for UART3
- Fix SetFrequency implementation - Update SetClockSource implementation
/clang-format-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this - To be honest, I only looked at the SVD files to check what parts were using UART RevB. D:
Completely missed this, but the UART RevB drivers are using chip-specific register definitions instead of the generic RevB ones: msdk/Libraries/PeriphDrivers/Source/UART/uart_revb.c Lines 286 to 317 in 6b6f2c3
ME16 builds are complaining due to this. |
Description
Fixes functional regression caused by #1113
Calls to MXC_UART_RevB_SetFrequency weren't updated for these parts after changing the RevB API. As a result,
MXC_UART_RevB_GetTXFIFOAvailable
would eventually hang as the UART FIFO compeltely fills up and is never emptied due to misconfiguration.Symptoms were that
printfs
would eventually infinitely hang. i.e. evenHello_World
wouldn't work.This PR should fix the regressions.
Also removed
MXC_UART1
andMXC_UART3
definitions for ME16. These don't exist on the micro.