Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Build): Don't update version when working in non-GitHub environments #1199

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

sihyung-maxim
Copy link
Contributor

@sihyung-maxim sihyung-maxim commented Oct 1, 2024

Description

This was added after the March 2024 release. Before this change, I noticed a non-critical python error at the beginning of the build.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@AbbyWolf-ADI AbbyWolf-ADI self-requested a review October 1, 2024 18:21
@sihyung-maxim sihyung-maxim merged commit aee8e41 into main Oct 1, 2024
10 checks passed
@sihyung-maxim sihyung-maxim deleted the fix/build_version_update branch October 1, 2024 18:22
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants