Disabled SDCARD as the default mode for Feather board, CODEC support Added. Updated weight… #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to improve the classification of unknown words and detection in the presence of background sound, Increased the acceptance threshold for the inference confidence and declare a class as unknown if it was less than threshold.
vicloginov
reviewed
Nov 23, 2022
| @@ -360,8 +372,7 @@ The LED | |||
|
|
|||
| - stays *green* when it is listening | |||
| - blinks *green* if a keyword is detected | |||
| - blinks *red* if an unknown keyword is detected | |||
| - blinks *yellow* if detection confidence is low | |||
| - blinks *yellow* if detection confidence is low or unknow keyword | |||
vicloginov
reviewed
Nov 23, 2022
|
|
||
| In this mode, the left channel (tip of the J5 3.5mm audio jack) of the line-in of MAX9867 audio CODEC (is used as the audio input source. | ||
|
|
||
| To enable using CODE as the audio input source, make sure the `PROJ_CFLAGS" line is uncommented. This mode can only be enabled for the Feather board. |
aniktash
changed the title
aniktash
changed the title
vicloginov
reviewed
Nov 28, 2022
| #define MAX9867_REVID 0x42 | ||
|
|
||
| // Register addresses | ||
| #define MAX9867_00_STATUS 0x00 |
There was a problem hiding this comment.
Maybe move #defines into max9867.h
Jake-Carter
suggested changes
Nov 28, 2022
| @@ -61,13 +61,17 @@ | |||
| #include "cnn.h" | |||
| #ifdef BOARD_FTHR_REVA | |||
| #include "tft_ili9341.h" | |||
| #ifdef ENABLE_CODEC_MIC | |||
| #include "i2c.h" | |||
| #include "max9867.h" | |||
There was a problem hiding this comment.
@aniktash @vicloginov FYI Jesse added some codec drivers to Libraries/MiscDrivers/CODEC in #240. We should use those drivers instead
Jake-Carter
approved these changes
Nov 29, 2022
| TFT_Print(buff, 1, 50, font_1, | ||
| snprintf(buff, sizeof(buff), "__________________________ ")); | ||
| TFT_Print(buff, 1, 80, font_1, snprintf(buff, sizeof(buff), "Top classes:")); | ||
| //TFT_Print(buff, 1, 80, font_1, snprintf(buff, sizeof(buff), "Top classes:")); |
There was a problem hiding this comment.
Delete commented code?
There was a problem hiding this comment.
I'd rather keep it in case somebody wants to see top 5 classes.
There was a problem hiding this comment.
Any downside to printing out top1/top5 by default? Or is it too cluttered?
Fine by me, just needs a "uncomment to print top5" type comment I think
| TFT_Print(buff, 20, 80 + 20 * top, font_1, | ||
| snprintf(buff, sizeof(buff), "%s (%0.1f%%)", keywords[max_index], | ||
| (double)100.0 * max / 32768.0)); | ||
| //TFT_Print(buff, 20, 80 + 20 * top, font_1, |
There was a problem hiding this comment.
Delete commented code?
There was a problem hiding this comment.
I'd rather keep it in case somebody wants to see top 5 classes.
Jake-Carter
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to improve the classification of unknown words and detection in the presence of background sound, Increased the acceptance threshold for the inference confidence and declare a class as unknown if it was less than threshold.