Add missing display examples (MAX32672FTHR & MAX32665EvKIT) #378

ozersa · 2023-02-01T11:12:14Z

MAX32665EvKit and MAX32672FTHR have display but there are driver and use case examples.
Added display examples for these devices, examples developed based on LVGL library.

LVGL v8.3.3 version library added inside libs folder
Added MAX32672 FTHR display (CFAL12832C) driver & use case example
Added MAX32665 EvKIT display (LS013B7DH03) driver & use case example
Update deice example list.

Examples:

sihyung-maxim

The source and header files in the Examples are missing copyright notices. I don't know if the copyright notice in Libraries/LVGL/lvgl/LICENCE.txt also extends toward the new Display Examples' source and header files.

But your changes looks good.

sihyung-maxim · 2023-02-01T16:39:04Z

Examples/MAX32665/Display/test_screen.h

+/*
+ * test_screen.h
+ *
+ *  Created on: Dec 7, 2022
+ *      Author: AKara
+ */


Add a copyright notice

Good catch!

Done, see 074bb88

sihyung-maxim · 2023-02-01T16:39:14Z

Examples/MAX32665/Display/test_screen.c

@@ -0,0 +1,42 @@
+#include "test_screen.h"


Add a copyright notice?

Done, see 074bb88

sihyung-maxim · 2023-02-01T16:39:26Z

Examples/MAX32665/Display/resources/adi_logo_alpha1.c

@@ -0,0 +1,35 @@
+#if defined(LV_LVGL_H_INCLUDE_SIMPLE)


Add a copyright notice?

Done, see 074bb88

sihyung-maxim · 2023-02-01T16:42:10Z

Examples/MAX32672/OLED_Demo/resources/adi_logo_alpha1.c

+#if defined(LV_LVGL_H_INCLUDE_SIMPLE)
+#include "lvgl.h"
+#else
+#include "lvgl/lvgl.h"
+#endif


Missing copyright notice

Done, see 074bb88

Jake-Carter

Looks good, we've needed this!

See review notes below. I think there is a simple change to the build system we can make to simplify things. There is also a more long-term question about consolidating to the common display.h approach for our other drivers

Jake-Carter · 2023-02-01T18:37:50Z

Libraries/Boards/MAX32665/EvKit_V1/Source/board.c

@@ -67,6 +81,73 @@ const mxc_gpio_cfg_t led_pin[] = {
 };
 const unsigned int num_leds = (sizeof(led_pin) / sizeof(mxc_gpio_cfg_t));

+#ifndef NO_DISPLAY


I suggest we should reverse the logic here and change this option to

#ifdef ENABLE_DISPLAY

... or some similar name.

Otherwise all examples that do not use the display will need to manually disable it.

Done, see 074bb88

Jake-Carter · 2023-02-01T18:38:45Z

Examples/MAX32672/OLED_Demo/project.mk

+SBT=0
+
+# Enforce to use FTHR board, the example works on FTHR only.
+BOARD = FTHR


Use

override BOARD = FTHR

to force FTHR in VS Code/Eclipse too

Done, see 074bb88

Jake-Carter · 2023-02-01T18:42:50Z

Libraries/LVGL/lvgl.mk

+ ###############################################################################
+
+ifeq "$(LVGL_DIR)" ""
+$(error LVGL_DIR must be specified")


Consider making this Makefile self-locating

Done, see 074bb88

Jake-Carter · 2023-02-01T18:50:32Z

Libraries/libs.mk

+LIB_LVGL ?= 0
+ifeq ($(LIB_LVGL), 1)
+LVGL_DIR ?= $(LIBS_DIR)/LVGL
+include $(LVGL_DIR)/lvgl.mk


I suggest exposing an ENABLE_DISPLAY option here with a default of 1.

# libs.mk # lvgl (Disabled by default) # ************************ LIB_LVGL ?= 0 ifeq ($(LIB_LVGL), 1) LVGL_DIR ?= $(LIBS_DIR)/LVGL ENABLE_DISPLAY ?= 1 # <-- (expose option here) include $(LVGL_DIR)/lvgl.mk endif

# lvgl.mk # ... ifeq($(ENABLE_DISPLAY),1) PROJ_CFLAGS += -DENABLE_DISPLAY # <-- (set compiler definition here) endif # ...

Combined with reversing the compiler definition logic above this will have the following effect:

if LIB_LVGL is 1, the display is automatically enabled.

if LIB_LVGL is 0, the display is disabled

Therefore LIB_LVGL=1 in project.mk is enough, and we do not need to manually maintain the display enable/disable for each example.

Done, see 074bb88

Jake-Carter · 2023-02-01T19:01:47Z

Libraries/MiscDrivers/Display/display.h

+    int (*write)(uint8_t *data, uint32_t data_len);
+    uint8_t *comm_buffer;
+    uint32_t comm_buffer_len;
+} display_comm_api;


Re-adding a common display header is a good change. I think we should consider this for use with the other displays and think about the common API a little more.

I have implemented the following scheme for the st7789v drivers:

Declare SPI transport layer functions as "extern" (Init/Read/Write): https://github.com/Analog-Devices-MSDK/msdk/blob/7c709440f43bec33167c26b1491d0017084edee0/Libraries/MiscDrivers/Display/tft_st7789v.h#L148

Implement them in board.c: https://github.com/Analog-Devices-MSDK/msdk/blob/7c709440f43bec33167c26b1491d0017084edee0/Libraries/Boards/MAX78000/EvKit_V1/Source/board.c#L92

This is very similar to the approach you have taken here. So I wonder if we can consolidate the other drivers to also use this common header, and choose between the "extern" approach or this common struct with function pointers.

Lets apply this change by another dedicated PR.

Jake-Carter · 2023-02-01T19:02:38Z

Examples/MAX32665/Bootloader/project.mk

@@ -18,6 +18,9 @@ MXC_OPTIMIZE_CFLAGS=-Os
 # Strip debug symbols
 DEBUG=0

+# To close display related code in board.c file
+PROJ_CFLAGS+=-DNO_DISPLAY


This may not be necessary - see other review notes.

Done, see 074bb88

- Remove unneeded includes - Run clang format - Update clang format script to pass lvgl lib too - Remove uneeded LVGL_LIB flag - Update examples list - Update library makefile Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>

Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>

- Change #include "lvgl/lvgl.h" to "lvgl.h" so MSDKGen can detect LVGL usage - Regenerate Eclipse and VS Code project files to add LVGL search paths - Regenerate core Makefile (minor tweaks, update links to online UG)

Jake-Carter

Thanks @ozersa, looks good!

FYI I updated the project files with MSDKGen in 3b56385 and bc8dc2e to add the LVGL paths to Eclipse/VS Code.

Let me know if it looks good to merge.

For a future PR:

Enable MiscDrivers for all micros (we still have a lot that are still using led.c/pb.c, etc. in their own boards directory)
Use common display.h API for all Display drivers

ozersa · 2023-02-03T06:49:01Z

@Jake-Carter It is ok, please feel free to merge it. Thanks.

ozersa requested review from Jake-Carter and sihyung-maxim February 1, 2023 11:12

ozersa force-pushed the dev-display_examples_based_on_lvgl_lib branch 4 times, most recently from 1e40078 to b3c27bb Compare February 1, 2023 11:48

sihyung-maxim reviewed Feb 1, 2023

View reviewed changes

Jake-Carter suggested changes Feb 1, 2023

View reviewed changes

karaanil and others added 11 commits February 2, 2023 11:35

[MSDK-978] LVGL8.3.3 MSDK Add

1285cba

[MSDK-980] LVGL Connect With libs.mk

8f4ef2a

[MSDK-964] ME21: FTHR OLED Display Driver Implementation

58daa4d

[MSDK-977] ME21: FTHR OLED Display Use Case Example

23cb13e

Makefile minor change

7449e51

[MSDK-985] ME14: EvKit Display Driver Implementation

90825e2

[MSDK-986] ME14: EvKit Display Use Case Example

92c0972

Review lvgl porting and apply related updates

e70413e

- Remove unneeded includes - Run clang format - Update clang format script to pass lvgl lib too - Remove uneeded LVGL_LIB flag - Update examples list - Update library makefile Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>

run clang format check in MiscDriver/Display folder

8253a27

Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>

Add option to remove display related code in project

00a7b8c

Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>

PR review update

074bb88

Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>

ozersa force-pushed the dev-display_examples_based_on_lvgl_lib branch from beca947 to 074bb88 Compare February 2, 2023 08:41

Jake-Carter added 3 commits February 2, 2023 14:05

Add libinfo for LVGL

ac9bb4d

(MSDKGen) Update project files

3b56385

- Change #include "lvgl/lvgl.h" to "lvgl.h" so MSDKGen can detect LVGL usage - Regenerate Eclipse and VS Code project files to add LVGL search paths - Regenerate core Makefile (minor tweaks, update links to online UG)

Whitelist MAX32665 & MAX32672 for MiscDrivers and regen

bc8dc2e

Jake-Carter approved these changes Feb 2, 2023

View reviewed changes

sihyung-maxim approved these changes Feb 6, 2023

View reviewed changes

sihyung-maxim merged commit 22eead3 into main Feb 6, 2023

sihyung-maxim deleted the dev-display_examples_based_on_lvgl_lib branch February 6, 2023 20:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing display examples (MAX32672FTHR & MAX32665EvKIT) #378

Add missing display examples (MAX32672FTHR & MAX32665EvKIT) #378

ozersa commented Feb 1, 2023 •

edited

Loading

sihyung-maxim left a comment

sihyung-maxim Feb 1, 2023

ozersa Feb 2, 2023

ozersa Feb 2, 2023

sihyung-maxim Feb 1, 2023

ozersa Feb 2, 2023

sihyung-maxim Feb 1, 2023

ozersa Feb 2, 2023

sihyung-maxim Feb 1, 2023

ozersa Feb 2, 2023

Jake-Carter left a comment

Jake-Carter Feb 1, 2023

ozersa Feb 2, 2023

Jake-Carter Feb 1, 2023

ozersa Feb 2, 2023

Jake-Carter Feb 1, 2023

ozersa Feb 2, 2023

Jake-Carter Feb 1, 2023

ozersa Feb 2, 2023

Jake-Carter Feb 1, 2023

ozersa Feb 2, 2023 •

edited

Loading

Jake-Carter Feb 1, 2023

ozersa Feb 2, 2023

Jake-Carter left a comment

ozersa commented Feb 3, 2023

Add missing display examples (MAX32672FTHR & MAX32665EvKIT) #378

Add missing display examples (MAX32672FTHR & MAX32665EvKIT) #378

Conversation

ozersa commented Feb 1, 2023 • edited Loading

sihyung-maxim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jake-Carter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ozersa Feb 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jake-Carter left a comment

Choose a reason for hiding this comment

ozersa commented Feb 3, 2023

ozersa commented Feb 1, 2023 •

edited

Loading

ozersa Feb 2, 2023 •

edited

Loading