Integrate bootloader with OTAS program code #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-gillespie
requested changes
Mar 7, 2023
There was a problem hiding this comment.
I think we can add something like this to the client project.mk to build the .bin file without the bootloader section.
# Create binary output file without the bootloader
%.bin.noboot: %.elf
@if [ 'x${VERBOSE}' = x ]; \
then \
echo "Creating ${@}"; \
echo "Excluding bootloader section"; \
else \
echo ${OBJCOPY} -O binary --remove-section .bootloader $(call fixpath,${<}) $(call fixpath,${@}); \
fi
@$(OBJCOPY) -O binary --remove-section .bootloader $< $(call fixpath,${@})| @@ -31,6 +31,8 @@ SRCS += stack_dats.c | |||
| SRCS += dats_main.c | |||
| SRCS += main.c | |||
|
|
|||
| PROJ_CFLAGS += -Wl,--section-start=.text=0x10004000 | |||
There was a problem hiding this comment.
Do we need this line? I think the linker fill will put the text section at this address.
There was a problem hiding this comment.
doesn't look like we do, I've removed it
kevin-gillespie
requested changes
Mar 9, 2023
| .bootloader : | ||
| { | ||
| KEEP(*bootloader.o) | ||
| } |
There was a problem hiding this comment.
We need the > BOOT here.
EdwinFairchild
approved these changes
Mar 10, 2023
|
Added a bug fix that this helped discover. |
kevin-gillespie
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OTAS makefiles to automatically compile and flash the bootloader application