Cordio lib #492
Cordio lib #492
Conversation
|
/clang-format-run |
1 similar comment
|
/clang-format-run |
This will allow us to build application with our without trace, without experiencing link errors. We will still have an issue with code size if the library is built with TRACE=2 and the application is built with TRACE=0. We won't see the trace messages, but the code size will be elevated. In the case where we go from TRACE=0 to TRACE=2, we won't see the print statements at all.
| @@ -218,7 +218,31 @@ void WsfTrace(const char *pStr, ...) | |||
| } | |||
| } | |||
| } | |||
| #endif | |||
| #if WSF_TRACE_ENABLED_VERBOSE == TRUE | |||
There was a problem hiding this comment.
This will allow the build to pass, but will cause problems when the trace options change. Still not sure which outcome is better.
TRACE options could require a re-build between applications. If the library is built with TRACE=0 it will be optimized for code size and remove all of the trace messaging. Adjacent applications will still build and link with TRACE=1, but the trace messages will not be printed until the library is re-built.
If the library is built with TRACE=2 and adjacent applications build with TRACE=0, the messages will not be printed, but the text will remain in the code space until the library is rebuilt with the appropriate option.
|
Pay special attention to Libraries/Cordio, specifically the build folder. |
|
This is ready for review. Please focus on the changes made to Libraries/Cordio. I'm most concerned about the TRACE changes. |
There was a problem hiding this comment.
@kevin-gillespie From a build system perspective I think this looks good and is a major improvement.
Since TRACE affects the build significantly, I made a small tweak so the different trace levels build as their own variants. See 7c8efb4
This makes TRACE changes transparent to the user and removes some documentation overhead. project.mk can be updated to remove the comment about rebuilding Cordio on TRACE changes. What do you think?
Correct. We shouldn't have to modify the CI. |
I thought about this and I think it will work fine. My concern is that the variants will grow out of control if we're not careful. I will update the comments and docs to reflect this. |
Yeah we definitely don't want to over-rely on this. I also kicked around the idea of writing all the options into a text file for each build. We could update the rule to build the library to compute a hash for the old file vs the new file. On hash difference we trigger a full rebuild. This adds a lot of external dependencies to the rule though. Maybe a task for a future PR, but could be applicable towards other libs as well. |
|
@kevin-gillespie |
Building a Cordio library. I used the peripheral driver layout as a reference.
TODO: Select files that need to be re-built for each application.