Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTC: Added missing OSCCTRL control bits across all parts. #503

Merged
merged 23 commits into from
Mar 28, 2023
Merged

RTC: Added missing OSCCTRL control bits across all parts. #503

merged 23 commits into from
Mar 28, 2023

Conversation

sihyung-maxim
Copy link
Contributor

No description provided.

@sihyung-maxim
Copy link
Contributor Author

/generate-register-files

@sihyung-maxim
Copy link
Contributor Author

/generate-register-files

@sihyung-maxim
Copy link
Contributor Author

/generate-register-files

@sihyung-maxim
Copy link
Contributor Author

/generate-register-files

@sihyung-maxim
Copy link
Contributor Author

Excluding ME13 and ME55 from the Verify_Register_SVD workflow since their register development is still undergoing changes in their respective branches, the main branch does not have any of those changes merged resulting in errors with the workflow.

@sihyung-maxim
Copy link
Contributor Author

Don't mind the failed Verify_Register_SVD check. For some reason, the action is trying to find usbhs_regs.h for the AI85 even though the AI85 doesn't list or support the USB SVD. Finding a solution to this.

@lorne-maxim
Copy link
Contributor

@sanjayjaroli should review the USB regs that were removed to make sure this isn't going to cause any issues with the USB library.

sanjayjaroli
sanjayjaroli suggested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@sanjayjaroli sanjayjaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the changes with mushhdfc_pg documentation. USB register changes look good to me.
Requesting a minor change for the RTC oscillation register description.

Libraries/PeriphDrivers/Source/RTC/rtc_reva_me14.svd Outdated
@@ -335,6 +335,30 @@
<addressOffset>0x18</addressOffset>
<resetMask>0x00000000</resetMask>
<fields>
<field>
<name>FILTER_EN</name>
<description>Enable analog deglitch filter.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Enable" to "Enables".
The same needs to change to other files too.

@sihyung-maxim sihyung-maxim merged commit f104fcf into main Mar 28, 2023
@sihyung-maxim sihyung-maxim deleted the dev/add-rtc-register branch March 28, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjayjaroli sanjayjaroli sanjayjaroli approved these changes

@lorne-maxim lorne-maxim lorne-maxim approved these changes

@Jake-Carter Jake-Carter Jake-Carter approved these changes

@cwarer1 cwarer1 cwarer1 approved these changes

@Jacob-Scheiffler Jacob-Scheiffler Awaiting requested review from Jacob-Scheiffler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sihyung-maxim @lorne-maxim @cwarer1 @Jake-Carter @sanjayjaroli