Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRC files for MAX32672 #531

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

Jake-Carter
Copy link
Contributor

CRC functionality for the MAX32672 exists within the CTB peripheral block. The CRC files were unused and misleading, so they've been removed.

Users looking for CRC functionality should check the CTB peripheral block documentation. CRC functions exist under MXC_CTB_CRC_xxx function headers.

Resolves #527

@Jake-Carter
Copy link
Contributor Author

@EdwinFairchild RF_Test is missing a semicolon as of #481

Can you fix the build and push to this branch? Thanks

@EdwinFairchild
Copy link
Contributor

EdwinFairchild commented Mar 31, 2023

@EdwinFairchild RF_Test is missing a semicolon as of #481

Can you fix the build and push to this branch? Thanks

how the heck
Fixed on main
Im not sure how to push it to your fork

@Jake-Carter
Copy link
Contributor Author

Jake-Carter commented Mar 31, 2023

@EdwinFairchild RF_Test is missing a semicolon as of #481
Can you fix the build and push to this branch? Thanks

how the heck Fixed on main Im not sure how to push it to your fork

Thanks!

FYI:

git remote add jake git@github.com:Jake-Carter/msdk.git
git fetch jake
git checkout remotes/jake/gh-527
git switch -c yourbranch
# commit...
git push jake yourbranch:gh-527

@EdwinFairchild
Copy link
Contributor

git remote add jake git@github.com:Jake-Carter/msdk.git
git fetch jake
git checkout remotes/jake/gh-527 -b yourbranch
git push jake yourbranch:gh-527

Solid info thanks!!!

@Jake-Carter
Copy link
Contributor Author

@sihyung-maxim looks like verify registers/SVD doesn't work on forks?

@Jake-Carter Jake-Carter marked this pull request as ready for review March 31, 2023 17:26
@sihyung-maxim
Copy link
Contributor

@sihyung-maxim looks like verify registers/SVD doesn't work on forks?

Not sure why the job failed for this fork even though it passed in your other fork for PR #521. I've specified the context of the checkout action to make sure it checks out the PR's repo (fork) and head of the source branch instead of letting the runner default those locations.

@Jake-Carter Jake-Carter merged commit 85dd5ea into analogdevicesinc:main Apr 3, 2023
@Jake-Carter Jake-Carter deleted the fix/gh-527 branch April 3, 2023 15:21
@Jake-Carter Jake-Carter added the API Change This issue or pull request involves a change to the current MSDK API label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change This issue or pull request involves a change to the current MSDK API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAX32672 (ME17) Has "crc.h"
3 participants