Build System: Add project.mk as a Watched Dependency File #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
added
the
build system
|
@EricB-ADI @AbbyWolf-ADI @EdwinFairchild @yc-adi please have a look, thanks |
yc-adi
approved these changes
May 19, 2023
|
works on my linux end |
Jacob-Scheiffler
approved these changes
May 19, 2023
- exporting PROJECTMK caused a regression for projects like BLE_otac/BLE_otas. The "source" project would call into the other project's makefile, but exporting PROJECTMK would use the host project.mk file for everything
sihyung-maxim
approved these changes
May 22, 2023
- Add support for PROJECTMK variable
|
good for me |
|
The time has come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add project.mk as a watched dependency file for the build system, which will address a lot of the issues we've been having lately, especially with Cordio library build options.
Any time project.mk changes a complete rebuild will be triggered including all library files.
These changes have been applied to the MAX32655 BLE_dats project for review/testing but are representative of what will go out to all micros. Please test this on your machine and confirm it works.