Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Build): Link with libphy_hard.a when MFLOAT_ABI = hard #676

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

khpeterson
Copy link
Contributor

Pull Request Template

Description

BLE builds fail when MFLOAT_ABI = hard, e.g. with macOS 12.6.7:

khp@Kevins-MacBook-Pro-M1 BLE_periph_20230718 % make all VERBOSE=1 BOARD=FTHR PROJECT=BLE_periph_20230718 TARGET=MAX32665 MFLOAT_ABI=hard
.
.
.
arm-none-eabi-gcc @/Users/khp/Dropbox/Projects/Documents/MXC/Examples/BLE_periph_20230718/build/ln_args.txt
/usr/local/gcc-arm-none-eabi-9-2020-q2-update/bin/../lib/gcc/arm-none-eabi/9.3.1/../../../../arm-none-eabi/bin/ld: error: /Users/khp/Dropbox/Projects/Documents/MXC/Examples/BLE_periph_20230718/build/BLE_periph_20230718.elf uses VFP register arguments, /Users/khp/Dropbox/Projects/Documents/MXC/Examples/msdk/Libraries/BlePhy/MAX32665/libphy.a(pal_bb.o) does not

Changed libs.mk to select libphy_hard.a when appropriate.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related Github issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@khpeterson khpeterson changed the title fix(Build): link with libphy_hard.a when MFLOAT_ABI = hard Fix(Build): link with libphy_hard.a when MFLOAT_ABI = hard Jul 18, 2023
@khpeterson khpeterson changed the title Fix(Build): link with libphy_hard.a when MFLOAT_ABI = hard fix(Build): link with libphy_hard.a when MFLOAT_ABI = hard Jul 18, 2023
@khpeterson khpeterson changed the title fix(Build): link with libphy_hard.a when MFLOAT_ABI = hard fix(Build): Link with libphy_hard.a when MFLOAT_ABI = hard Jul 18, 2023
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @khpeterson, I appreciate the PR. Good catch on this.

I've added some hardfp tests to our build checker (7ab2e87) which should help this from slipping through again.

@Jake-Carter Jake-Carter merged commit 136b2f7 into analogdevicesinc:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants