fix(PeriphDrivers): Fix MAX32675, MAX32680 A5 Silicon AFE Init, and Speedups #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix probing of AFE version. Had incorrect define on earlier version. Updated HART UART driver to correctly handle new POR versus Reset behavior after seeing this not work on latest silicon (ME16A-1E). Precise procedure must be followed to maintain HART analog biases.
Found current timeout based scheme is a bit slow for requested performance. Supporting both methods at least at compile time via define: AFE_SPI_TRANSCEIVE_SAFE_BUT_SLOWER Also updated timeout for register access.
HART registration as a Modem requires driving of the HART UART signals via external UART connection. This change places these pins into a safe mode allowing external PC to drive these lines as necessary.
github-actions
bot
added
MAX32675
sihyung-maxim
approved these changes
Dec 13, 2023
WilliamDock
reviewed
Dec 14, 2023
WilliamDock
reviewed
Dec 14, 2023
WilliamDock
reviewed
Dec 14, 2023
WilliamDock
reviewed
Dec 14, 2023
WilliamDock
reviewed
Dec 14, 2023
WilliamDock
approved these changes
Dec 14, 2023
Jake-Carter
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Corrects AFE initialization issue on latest MAX32675 silicon.
Changes to AFE driver to speed up communications. Increased SPI clock rate from 100KHz, to 1Mhz, and added define AFE_SPI_TRANSCEIVE_SAFE_BUT_SLOWER to allow compile time choice between timer based infinite loop protection, as was previously used, and the faster version without timeouts used by default now.
Adds HART_TEST_MODE_EXTERNAL this "Tristates" the HART Uart pins to allows them to be driven from off board PC. This mode is required during HART registration testing as a Modem (Secondary Master).
Validated working on MAX32675.
Checklist Before Requesting Review