feat(Examples,MiscDrivers): Add ADT7320 Temperature Sensor Driver and Example for MAX32665 #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADT7320 example added to the examples.
ersahatmacaa
requested review from
Jake-Carter,
ozersa,
lorne-maxim and
sihyung-maxim
Jake-Carter
suggested changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks @ersahatmacaa, looks good. A few minor change requests below related to the build system.
Also, FYI the include paths were missing for the TempSensor folder.
I have not done a good job of documenting this yet, but the way you can fix this is by adding the folder to the library's libinfo.json file, and then running MSDKGen.
I updated libinfo here: 8d8118b
and then ran MSDKGen on the project: 32ce059
I'll add some better documentation on the libinfo.json files in our contributing guidelines in the future.
Moved adt7320 drivers from Libraries/Boards/MAX32665/xx/board.mk to project.mk.
sihyung-maxim
requested changes
Jan 12, 2024
Typo on ReadMe.md fixed
sihyung-maxim
approved these changes
Jan 15, 2024
Jake-Carter
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented a new temperature monitoring example project for the MAX32665, which operates with the ADT7320 SPI temperature sensor. The example project located under Examples\MAX32665 and, the sensor drivers under Libraries\MiscDrivers\TempSensor directory.