fix(BLE): PalTimer Calibration #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is good, I am wondering why you cast the uint32_t to an int. It seems intentional, but not obvious as to why? |
|
usecDiff can be negative, and the with the implicit conversion between the signed and unsigned types, I was getting incorrect values. Looking at it though, int should probably be int32_t for consistency. Let me push up a change using the stdint type instead. |
BrentK-ADI
force-pushed
the
ble_paltimer_fix
branch
from
430fc07 to
949a69e
Compare
…n a 100ms boundary.
BrentK-ADI
force-pushed
the
ble_paltimer_fix
branch
from
949a69e to
6f5ab8b
Compare
|
Pushed up the wrong branch and made a big mess. 6f5ab8b should be good now. |
EricB-ADI
approved these changes
Mar 15, 2024
EricB-ADI
pushed a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 65259f2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code for calibrating the PalTimer against the 32MHz clock. Original implementation only added adjustment on 100ms (PAL_TMR_CALIB_TIME) boundaries. In cases where the timer time was in between 100ms intervals, the timer could be severely early or late depending on how large usecDiff is.
``
The math could be accomplished by simply running
(expUsec * palTimerCb.usecDiff) / PAL_TMR_CALIB_TIME;however there is not enough objective evidence for the max values of expUsec and usecDiff to show the multiplication won't overflow 32-bits. The math could be done in 64-bits, however the modulo method was used to keep this within a 32-bit scope.