Merging master to fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Translib changes phase I * Translib changes phase I * Resolved the review comments * Returning nil for the error parameter
YGOT:- To improve the performance of the Unmarshal and EmitJSON methods. Caching the schema information to path instead of finding the schema for the path every time. Disabled the validation of the response while marshaling the ygot object. Added the debug check for the debug logs to get generated/printed only when the debug flag is enabled Fixes in the Unmarshal method for the node leaf-list, and leaf contains union which has enum as one of its type. Added changes in the Unmarshal method to throw an error if the request payload has the state information. Request Binder:- Added the method validateObjectType - to check and throw an error if the given request payload contains state information. Added the changes not to validate the request payload if the model of the payload is sonic yang, since CVL validates the sonic yang model request Package update:- Updated the ygot package to the version v0.7.1 Updated the goyang package to the version v0.0.0-20200309174518-a00bece872fc Updated the gnmi package to the version v0.0.0-20200307010808-e7106f7f5493
anand-kumar-subramanian
pushed a commit
that referenced
this pull request
Jul 31, 2020
…ges (sonic-net#18) - Why I did it As part of CVL code update and new features addition, the existing CVL code has to be reorganized and common infra needs to be changed. - How I did it N/A. Please refer to change log for more details. - How to verify it No specific test cases to be executed. Run cvl go test cases using - 'make cvl-test'. - Description for the changelog Modify Makefiles Modify CVL Makefile for cleanall rule Modify Makefile for CVL YIN schema generation Modify Makefile for CVL test YIN schema generation Moved cache, syntax and semantic related code from cvl.go to cvl_cache.go, cvl_syntax.go and cvl_semantics.go respectively . Added new API signatures for integration. Implementation will be added in subsequent PRs. Copied sonic-port.yang and sonic-acl.yang to CVL own's test folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging master to fork