Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release 2023.9 will abandon forecast attribute for weather entities #68

Closed
fursov opened this issue Sep 7, 2023 · 7 comments · Fixed by #69 or PolarFox/fmi-hass-custom#1
Closed

Comments

@fursov
Copy link

fursov commented Sep 7, 2023

https://www.home-assistant.io/blog/2023/09/06/release-20239/#weather-forecast-service

So the warning reported on my setup:

Logger: homeassistant.components.weather
Source: components/weather/__init__.py:339
Integration: Weather (documentation, issues)
First occurred: 08:54:47 (1 occurrences)
Last logged: 08:54:47

custom_components.fmi.weather::None is using a forecast attribute on an instance of WeatherEntity, this is deprecated and will be unsupported from Home Assistant 2024.3. Please report it to the custom integration author.

I think you noticed this issue yourself so I decided to create the ticket for tracking purposes only :)

@Hiekkaharju
Copy link

Hiekkaharju commented Sep 8, 2023

I just want to suggest that this change would be done in two phases = releases. First one asap - add support for the new service for getting the forecast. Second just before the attribute deprecation actually happens - remove the attribute. This way we users have some time to move to use the service and the attribute still works while we implement and test our changes. That would be especially good for those of us who use the forecast in automations.

@oleg-d
Copy link
Contributor

oleg-d commented Sep 9, 2023

image

@cruwaller
Copy link
Collaborator

@anand-p-r any update / comment?

@cruwaller
Copy link
Collaborator

@anand-p-r please check my PR for fix to this... Or let me know if you think something needs to be changed.

@boozeman
Copy link

boozeman commented Jan 4, 2024

I hope @anand-p-r is fine and everything is ok. I hope this is just because he doesn't have time to maintain the repository

@anand-p-r
Copy link
Owner

@cruwaller Thanks for tracking the changes. I have now added you as a collaborator. Hope this helps and sorry for not being very active here. Hopefully it will change in the near future.

@cruwaller
Copy link
Collaborator

@anand-p-r happy to hear from you and you are ok!
I created an organization to track your great work further. It will be easier for you and users to follow...
I added you as owner.
Maybe you could even move this repository to there? (and I will remove the existing fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants