Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a help command #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a help command #64

wants to merge 1 commit into from

Conversation

Wilfred
Copy link
Collaborator

@Wilfred Wilfred commented Sep 21, 2018

Using ? for help is a magit convention. Offer basic information on
keybindings by using Emacs' built-in help.

Fixes #59

@Wilfred
Add a help command
91c1c9f 
Using ? for help is a magit convention. Offer basic information on
keybindings by using Emacs' built-in help.

Fixes ananthakumaran#59
@Wilfred
Copy link
Collaborator Author

Wilfred commented Sep 21, 2018

Hmm, this doesn't show all bindings, such as :.

@Bounga
Copy link
Collaborator

Bounga commented Sep 21, 2018

@Wilfred That's because you ask to show keybindings for monky-status-mode there's no : binding in this mode. That's a monky-mode binding.

I think that in monky-status we want to see both monky-mode and monky-status-mode bindings. When viewing logs we want to see both monky-mode and monky-log-mode bindings and so on.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wilfred @Bounga