Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the linting support to support disabling eslint errors. #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lddubeau
Copy link
Collaborator

We also gain support for adding the @ts-ignore flag that the tsc compiler understands.

This change adds logic for identifying the general type of checker from which flycheck errors are reported, and so be able to add the right flag when the user requests that an error be turned off.

This tackles point 2 of this post.

I've been running this for a while in projects that use eslint for all linting work, and projects that still use tslint, and it's been working for me.

We also gain support for adding the @ts-ignore flag that the tsc compiler
understands.
@josteink
Copy link
Collaborator

Sorry about the late response.

If it's OK, I'll hold on investigating this PR, until the questions I've raised in #308 are put down or resolved 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants