Compatibility with Future StanHeaders #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the same issue #1 I opened in 2001. We need this PR to be merged and released to CRAN in order to release the StanHeaders that has been years in the making but is still years behind the current Stan development branch. Please do so this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the compilation flags for your package so that it will be compatible with the upcoming StanHeaders 2.26, which requires that packages link against the
RcppParallelpackage.I've updated your
MakevarsandMakevars.winfiles to use the compiler flags also recommended by therstantoolspackage (those makefiles can be found in full here).Feel free to let me know if you had any questions!