Merge pull request #448 from anatawa12/fix-merge-bone-will-break-normal

fix: MergeBone will break normal and tangent
anatawa12 · Sep 11, 2023 · 16d879d · 16d879d
2 parents fc56c25 + 40101fe
commit 16d879d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG-PRERELEASE.md b/CHANGELOG-PRERELEASE.md
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog].
 ### Removed
 
 ### Fixed
+- MergeBone will break Normal and Tangent `#448`
 
 ### Security
 

diff --git a/Editor/Processors/MergeBoneProcessor.cs b/Editor/Processors/MergeBoneProcessor.cs
@@ -134,6 +134,9 @@ private void DoBoneMap2(MeshInfo2 meshInfo2, Dictionary<Transform, Transform> me
  var transBindPose = finalBone.Bindpose.inverse * mergedOldBindPose;
 
  vertex.Position = transBindPose.MultiplyPoint3x4(vertex.Position);
+ vertex.Normal = transBindPose.MultiplyPoint3x3(vertex.Normal);
+ var tangentVec3 = transBindPose.MultiplyPoint3x3(vertex.Tangent);
+ vertex.Tangent = new Vector4(tangentVec3.x, tangentVec3.y, tangentVec3.z);
  foreach (var frames in vertex.BlendShapes.Values)
  {
  for (var i = 0; i < frames.Count; i++)