docs: add comments

anatawa12 · Oct 12, 2024 · af7fe67 · af7fe67
1 parent 5d11eec
commit af7fe67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/Editor/Processors/SkinnedMeshes/MergeSkinnedMeshProcessor.cs b/Editor/Processors/SkinnedMeshes/MergeSkinnedMeshProcessor.cs
@@ -229,6 +229,7 @@ public static void CopyEnablementAnimation(
  }
  }
 
+ // must preserve first material to be the first material for AutoMergeSkinnedMesh
  public static (int[][] subMeshIndexMap, List<(MeshTopology topology, Material? material)> materials)
  GenerateSubMeshMapping(
  MeshInfo2[] meshInfos,
@@ -567,6 +568,7 @@ private static HashSet<AnimationLocation> GetAnimationLocations(BuildContext con
  return locations;
  }
 
+ // must preserve first material to be the first material for AutoMergeSkinnedMesh
  private static (int[][] mapping, List<(MeshTopology topology, Material? material)> materials)
  CreateMergedMaterialsAndSubMeshIndexMapping((MeshTopology topology, Material? material)[][] sourceMaterials,
  HashSet<Material> doNotMerges)

diff --git a/Editor/Processors/TraceAndOptimize/AutoMergeSkinnedMesh.cs b/Editor/Processors/TraceAndOptimize/AutoMergeSkinnedMesh.cs
@@ -150,6 +150,7 @@ public static void MergeMeshes(BuildContext context, TraceAndOptimizeState state
 
  Func<MeshInfo2[], (int[][], List<(MeshTopology, Material?)>)> createSubMeshes;
 
+ // createSubMeshes must preserve first material to be the first material
  if (state.SkipMergeMaterials)
  createSubMeshes = CreateSubMeshesNoMerge;
  else if (state.AllowShuffleMaterialSlots)
@@ -258,6 +259,7 @@ private static void MergeAnimatingSkinnedMesh(
  var newMeshInfo = context.GetMeshInfoFor(newSkinnedMeshRenderer);
  var meshInfosArray = meshInfos.ToArray();
 
+ // もしAnimationがPatrially Appliedなことがある場合は初期値を取れるマテリアルを最初のスロットに適用するべきかも。createSubMeshesの中で
  var (subMeshIndexMap, materials) = createSubMeshes(meshInfosArray);
 
  MergeSkinnedMeshProcessor.DoMerge(context, newMeshInfo, meshInfosArray, subMeshIndexMap,
@@ -461,6 +463,7 @@ CategorizationKey key
  return newSkinnedMeshRenderer;
  }
 
+ // must preserve first material to be the first material
  public static (int[][], List<(MeshTopology, Material?)>) CreateSubMeshesNoMerge(MeshInfo2[] meshInfos)
  {
  var subMeshIndexMap = new int[meshInfos.Length][];
@@ -483,6 +486,7 @@ public static (int[][], List<(MeshTopology, Material?)>) CreateSubMeshesNoMerge(
  public static (int[][], List<(MeshTopology, Material?)>) CreateSubMeshesMergeShuffling(MeshInfo2[] meshInfos) =>
  MergeSkinnedMeshProcessor.GenerateSubMeshMapping(meshInfos, new HashSet<Material>());
 
+ // must preserve first material to be the first material
  public static (int[][], List<(MeshTopology, Material?)>) CreateSubMeshesMergePreserveOrder(MeshInfo2[] meshInfos)
  {
  // merge consecutive submeshes with same material to one for simpler logic