Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error reporting window improvements #216

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Error reporting window improvements #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e464fd
chore(error-report): initial commit for improving error report UI
anatawa12 Jun 8, 2023
f6802cb
chore(error-report): remove unused code
anatawa12 Jun 8, 2023
824e7fe
chore(error-report): extract header section to another class
anatawa12 Jun 8, 2023
f078366
fix: ui might not be updated after assembly reload
anatawa12 Jun 8, 2023
a92d1a7
chore: support for changing selected avatar
anatawa12 Jun 8, 2023
d82d715
fix: redrawing the window
anatawa12 Jun 8, 2023
605ae71
chore: improve no error message
anatawa12 Jun 8, 2023
e46af9f
fix: remove many error elements for debugging
anatawa12 Jun 8, 2023
2498dd5
chore: open error window for error avatar
anatawa12 Jun 8, 2023
742d975
feat: change to new default avatar if we selected old default avatar
anatawa12 Jun 8, 2023
5381463
docs(changelog): add Improve ErrorReport window on build error
anatawa12 Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-PRERELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog].
### Added

### Changed
- Improve ErrorReport window on build error `#216`

### Deprecated

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog].
### Added

### Changed
- Improve ErrorReport window on build error `#216`

### Deprecated

Expand Down
8 changes: 6 additions & 2 deletions Internal/ErrorReporter/Editor/BuildReport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,14 @@ private class AvatarReportScope : IDisposable
{
public void Dispose()
{
var successful = CurrentReport.CurrentAvatar.successful;
var avatar = CurrentReport.CurrentAvatar;
CurrentReport.CurrentAvatar = null;
var successful = avatar.successful;
BuildReport.SaveReport();
ErrorReportUI.MaybeOpenErrorReportUI();
if (avatar.logs.Any())
ErrorReportUI.OpenErrorReportUIFor(avatar);
else
ErrorReportUI.MaybeOpenErrorReportUI();
if (!successful) throw new Exception("Avatar processing failed");
}
}
Expand Down
Loading