Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ja/en): review of #327 #365

Merged
merged 1 commit into from
Aug 22, 2023
Merged

docs(ja/en): review of #327 #365

merged 1 commit into from
Aug 22, 2023

Conversation

Sayamame-beans
Copy link
Sponsor Collaborator

大変遅くなりましたが、レビューが終わりました。
変更抜け等あるかもしれません。

@Sayamame-beans Sayamame-beans added documentation Improvements or additions to documentation localization Improvements or additions to localization labels Aug 22, 2023
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです。

なにか書き換える際に定めた(揃えた)ルールなどがあればdocsのREADMEに追加していただけるとありがたいです

@Sayamame-beans
Copy link
Sponsor Collaborator Author

Sayamame-beans commented Aug 22, 2023

そうですね…全体に適用出来るようなものは特に無い気がします。
今回の中では、基本的に冠詞を付けるようにしたこと、分かりやすいように"コンポーネント", "component"を加えたこと、"thus"は", so"で統一したことなどが考えられますが…
全体的に、分かりやすくなりそうなように私が個人的に考えた表現に置き換えた結果という感じです。
ルールには至らないかなと

@Sayamame-beans Sayamame-beans merged commit 21f59cf into master Aug 22, 2023
11 checks passed
@Sayamame-beans Sayamame-beans deleted the 327-review-patch branch August 22, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation localization Improvements or additions to localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants