Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-mesh-by-blendshape/editor): auto set blendshape weight #389

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

anatawa12
Copy link
Owner

Fixes #387

@anatawa12 anatawa12 added the enhancement New feature or request label Aug 28, 2023
@anatawa12 anatawa12 marked this pull request as ready for review August 28, 2023 09:22
@Sayamame-beans
Copy link
Sponsor Collaborator

これはどういう場合に使うどういった機能なのでしょうか?

@anatawa12
Copy link
Owner Author

削除対象の頂点がわかりづらくなるためそれをけいげんするための機能です

(手動でweight100にするのだとミスが発生しやすい)

@Sayamame-beans
Copy link
Sponsor Collaborator

ふむ、確認用の機能ということですね。
現状のtooltipだと、日英ともに、対象BlendShapeをトグルすると自動的に100/0にする(何故?)という感じでよく分からず…

@Sayamame-beans
Copy link
Sponsor Collaborator

Sayamame-beans commented Aug 28, 2023

挙動をあまり理解出来ていないので、レビュー文章が組めていません。

@anatawa12
Copy link
Owner Author

チェックしたときにWeight = 100にしてチェック外したときにweight = 0にするってシンプルな動作です

@Sayamame-beans
Copy link
Sponsor Collaborator

あ~
当該オプションを有効にした時、削除対象として選択したblendshapeを100にすることで、100で縮むタイプのものをプレビューする感じですかね?
0で縮むタイプは無いのでしたっけ?

@anatawa12
Copy link
Owner Author

0で縮むタイプは無いのでしたっけ?

ないと思います。少なくとも想定外

Copy link
Sponsor Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとしっくり来てないですが、一旦これで

Localization/ja.po Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
Localization/en.po Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
anatawa12 and others added 2 commits August 30, 2023 00:58
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Localization/en.po Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Copy link
Sponsor Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分良いんじゃないでしょうか。
引っ掛かる気持ちが無いわけではないので、また何かあれば修正しましょう…

@anatawa12 anatawa12 merged commit 9ede0cb into master Aug 29, 2023
5 checks passed
@anatawa12 anatawa12 deleted the auto-set-weight branch August 29, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoveMesh By BlendShape Automatically set weight to 100/0 when toggle (editor only opt in)
2 participants