Disable AnimatorParserDebugWindow if VRCSDK is not present #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikoga
changed the title
kaikoga
changed the title
|
頭回ってないんで日本語で言います。 DebugTool、AAO Developerのためのやつではあるんですがtest以下等ではない理由はユーザの環境の結果を取ってバグを検討するためなのでAのほうが嬉しい。 デバック関連の細かい機能はSemver対象外のつもり。(これドキュメントすべきだな。) |
|
Thank you for your comment. I would force push this PR with Case A, taking the |
kaikoga
force-pushed
the
wrap_anim_parser_debug_window
branch
from
dc3e7cb
to
fdd928e
Compare
anatawa12
reviewed
Oct 20, 2023
Comment on lines
+18
to
19
| public GameObject avatar; | ||
| public GameObject rootGameObject; |
There was a problem hiding this comment.
AvatarもGameObjectだしrootGameObject共有していい気がします
There was a problem hiding this comment.
最初はそう思ったのですが、 rootGameObject はシーン置きのオブジェクトを受け付けない一方で avatar はプレハブを受け付けない（プレハブを受け付けるように改修することはできるがこのPRのスコープ外）ので、セマンティクスが異なると思います。
There was a problem hiding this comment.
明確な理由ないし別にObjectFieldのところでtrue / false揃ってる必要もあんまない(とくにdebug画面なので)なと思ってるのですがまぁOK
anatawa12
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #607
I have to do something with AnimatorParserDebugWindow because it contains
VRCAvatarDescriptorreference, however I don't know exactly how to deal with it.Case A:
This debug tool is useful for AAO users, so it is supposed work without VRCSDK.
ParserSource.WholeAvatarshould accept something like Animator or Transform for users who wants to edit non-VRChat avatars on projects with VRCSDK. (Warning: this is a breaking change for users with VRCSDK)Case B:
This is just a utility debug tool for AAO developers, so it can be safely removed if VRCSDK is not present (this PR).
Case C:
This debug tool is legacy and would be immediately demolished. 🤯
Any thoughts?