Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Enablement Mismatched Renderers #670

Merged
merged 14 commits into from
Nov 6, 2023
Merged

Skip Enablement Mismatched Renderers #670

merged 14 commits into from
Nov 6, 2023

Conversation

anatawa12
Copy link
Owner

Fixes #666

@anatawa12 anatawa12 added the enhancement New feature or request label Oct 31, 2023
@anatawa12 anatawa12 marked this pull request as ready for review October 31, 2023 01:00
@anatawa12 anatawa12 changed the title Skip initially disabled objects Skip Enablement Mismatched Renderers Oct 31, 2023
@anatawa12 anatawa12 force-pushed the skip-initially-disabled-objects branch from 2a1c107 to cf96e6b Compare October 31, 2023 01:16
@Sayamame-beans
Copy link
Sponsor Collaborator

"Enabled Mismatched Renderers"だと意味が伝わらないような気がします…?
まだ代替表現思いついてないです

@anatawa12
Copy link
Owner Author

EnabledじゃなくてEnablementだなとなったのでそうしたけどまだ分かりづらいかも

@Sayamame-beans
Copy link
Sponsor Collaborator

代替案迷子中

@Sayamame-beans
Copy link
Sponsor Collaborator

"State Mismatched Renderers"だとさすがにふわっとし過ぎですかね?
SMRで(表で触れて)stateにあたりそうなのはisActiveかなと考えて、辛うじて伝わるかなって思ったんですけど…

@anatawa12
Copy link
Owner Author

普通にBlendShape状態ではないですかね

@Sayamame-beans
Copy link
Sponsor Collaborator

普通にBlendShape状態ではないですかね

a---
じゃあ没で

Sayamame-beans
Sayamame-beans requested changes Nov 6, 2023
View reviewed changes
Copy link
Sponsor Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード内はEnabled表記のままですけど大丈夫です?

.docs/content/docs/reference/merge-skinned-mesh/component.png Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
.docs/content/docs/reference/merge-skinned-mesh/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/reference/merge-skinned-mesh/index.ja.md Outdated Show resolved Hide resolved
@anatawa12
Copy link
Owner Author

コード内はどっちでもいいと思ってるけど治すかぁ

Sayamame-beans
Sayamame-beans approved these changes Nov 6, 2023
View reviewed changes
Copy link
Sponsor Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@anatawa12 anatawa12 merged commit bd08ab7 into master Nov 6, 2023
5 checks passed
@anatawa12 anatawa12 deleted the skip-initially-disabled-objects branch November 6, 2023 10:50
@ReinaS-64892 ReinaS-64892 mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MergeSkinnedMesh: 最初からinactiveなGameObject/Rendererを無視するオプション
2 participants
@anatawa12 @Sayamame-beans