Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VRM component definitions #802

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Fix VRM component definitions #802

merged 3 commits into from
Dec 21, 2023

Conversation

kaikoga
Copy link
Contributor

@kaikoga kaikoga commented Dec 19, 2023

I don't know whether this branch should be based on master or master-1.6, so tell me when I need a rebase 😃

  • fix: animator at the avatar root disappears #711 but for VRM0 / VRM1 (Animator component is optional if you don't care animating Humanoid muscles in Unity Editor, which is mostly true if you are just building VRM files with UniVRM)
  • VRMSpringBone of VRM0 animates VRMSpringBone.RootBones, not children of VRMSpringBone component

@kaikoga kaikoga marked this pull request as ready for review December 19, 2023 22:29
@anatawa12
Copy link
Owner

当面1.7できそうにないので1.6でいいと思います

@anatawa12 anatawa12 added the bug Something isn't working label Dec 21, 2023
@anatawa12 anatawa12 merged commit 770ab4b into anatawa12:master-1.6 Dec 21, 2023
11 checks passed
@kaikoga kaikoga deleted the fix_vrm branch December 30, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatawa12 anatawa12 anatawa12 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaikoga @anatawa12