Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of Animator optimizer with EntryExit to 1D BlendTree #854

Merged
merged 30 commits into from
Jan 28, 2024
Merged

Initial commit of Animator optimizer with EntryExit to 1D BlendTree #854

merged 30 commits into from
Jan 28, 2024

Conversation

anatawa12
Copy link
Owner

Fixes #443

@anatawa12 anatawa12 added enhancement New feature or request a:AnimatorOptimizer planned feature AnimatorOptimizer labels Jan 26, 2024
@anatawa12 anatawa12 changed the title Animator optimizer (EntryExit to 1D BlendTree) Iniial commit of Animator optimizer with EntryExit to 1D BlendTree Jan 26, 2024
@anatawa12 anatawa12 changed the title Iniial commit of Animator optimizer with EntryExit to 1D BlendTree Initial commit of Animator optimizer with EntryExit to 1D BlendTree Jan 28, 2024
This was referenced Jan 28, 2024
Open
Open
anatawa12
anatawa12 commented Jan 28, 2024
View reviewed changes
Copy link
Owner Author

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分OK

@anatawa12 anatawa12 marked this pull request as ready for review January 28, 2024 15:38
Sayamame-beans
Sayamame-beans requested changes Jan 28, 2024
View reviewed changes
Localization/ja.po Outdated Show resolved Hide resolved
.docs/content/docs/reference/trace-and-optimize/index.ja.md Outdated Show resolved Hide resolved
@anatawa12
Copy link
Owner Author

Changelog忘れてたのでつけました

Sayamame-beans
Sayamame-beans reviewed Jan 28, 2024
View reviewed changes
Copy link
Sponsor Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog OK

@anatawa12 @Sayamame-beans
chore(ja): Apply suggestions from code review
5941a5b 
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Sayamame-beans
Sayamame-beans approved these changes Jan 28, 2024
View reviewed changes
Copy link
Sponsor Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分ヨシ!

@anatawa12 anatawa12 merged commit 4b76f89 into master Jan 28, 2024
5 checks passed
@anatawa12 anatawa12 deleted the animator-optimizer branch January 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
a:AnimatorOptimizer planned feature AnimatorOptimizer enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EntryExitをBlendTreeに変える
2 participants
@anatawa12 @Sayamame-beans