Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix VRM support #892

Merged
merged 3 commits into from
Feb 23, 2024
Merged

fix: Fix VRM support #892

merged 3 commits into from
Feb 23, 2024

Conversation

kaikoga
Copy link
Contributor

@kaikoga kaikoga commented Feb 11, 2024 •
edited
Loading

  • VRM には AvatarDescriptor はない
  • 表情（ VRM0 の BlendShapeClip / VRM1 の Expression ）が操作する対象の BlendShape は普通に重複しうる
    • (target, prop) が重複すると ComponentNodeContainer.Add() が失敗する
    • 「複数の表情が同じ BlendShape を操作する」は普通にあり得る
      • このパターンの場合、 NodeContainer や PropModeNode を真面目に書いていた可能性がある
    • 実際は「一つの表情で同じ BlendShape を複数回操作するデータが作れる」（ VRM は特に重複チェックをしていない）ので、大元で重複チェックすれば良いでしょうという感じになりました

@kaikoga kaikoga marked this pull request as ready for review February 18, 2024 13:12
anatawa12
anatawa12 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

@anatawa12 anatawa12 merged commit 2b689f0 into anatawa12:master Feb 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatawa12 anatawa12 anatawa12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaikoga @anatawa12