Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(merge-direct-blend-tree): merge non Direct BlendTree #980

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

nekobako
Copy link
Contributor

@nekobako nekobako commented Apr 3, 2024

Fixes #979 です

@nekobako nekobako marked this pull request as ready for review April 3, 2024 11:13
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほかは概ね良さそうです

ありがとうございます

@@ -23,11 +24,13 @@ public static void Execute(AOAnimatorController controller)

var modifiedProperties = new HashSet<EditorCurveBinding>();

var alwaysOneParameter = $"AlwaysOne_{Guid.NewGuid()}";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAOが追加したことを明記したいです

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先頭に AAO_ を付けました!

Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ありがとうございます!

@anatawa12 anatawa12 merged commit 55d90f5 into anatawa12:master Apr 4, 2024
8 checks passed
@nekobako nekobako deleted the merge-non-direct-blendtree branch April 4, 2024 10:22
@Sayamame-beans
Copy link
Sponsor Collaborator

@anatawa12 Merge"Direct"BlendTreeじゃなくなっちゃいませんか? (コンポーネント名 及び prereleaseでないchangelog など)

@anatawa12
Copy link
Owner

あー直さないといけないですね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct ではない BlendTree のマージ
3 participants